Skip to content

[ENG-7601] Ext image ext ipy updates #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

futa-ikeda
Copy link

@futa-ikeda futa-ikeda commented Jun 12, 2025

Ticket

ENG-7601

Purpose

  • Update dependencies for Images and IPython

Changes

  • Update requirements.txt
  • Address test failures in tests/extensions/

Side effects

  • I have a couple test failures left when running pytest tests/extensions/
    • One seems to be stemming from the fact that we are using xlrd==1.0.0 which causes AttributeError: module 'time' has no attribute 'clock' (seems to be deprecated as of Python 3.3).
      • Updating xlrd to 2.0.1 (latest) seems to cause some other issues of Excel xlsx file; not supported. Seems xlrd is just focusing on xls files according to this SO post
    • Another test failure is stemming from some issues in pydocx's memoize util. I made a PR to update that line, but may need to update the pydocx dependency to point to a branch with that update
  • I'm getting the familiar errors when running the full test suite RuntimeError: There is no current event loop in thread 'MainThread'., but those will be handled in a separate PR

QA Notes

Deployment Notes

@futa-ikeda futa-ikeda changed the title [WIP][ENG-7601] Ext image ext ipy updates [ENG-7601] Ext image ext ipy updates Jun 12, 2025
@felliott felliott force-pushed the ext-image-ext-ipy-updates branch from c430828 to 9eb5c7a Compare June 14, 2025 03:55
@felliott felliott merged commit adc4bc2 into CenterForOpenScience:feature/buff-worms Jun 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants